summaryrefslogtreecommitdiff
path: root/src/apps/qcam/viewfinder_gl.h
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2022-10-22 23:53:26 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2022-11-09 23:56:21 +0200
commita07968bed27638f799adb825266a8417f6f3cdb3 (patch)
tree9a5d03e3cb58ca72ff12cead588e117f2a39fef2 /src/apps/qcam/viewfinder_gl.h
parent00b650b6b813230eb328742c560236aa43465134 (diff)
libcamera: pipeline_handler: Return unique_ptr from generateConfiguration()
The PipelineHandler::generateConfiguration() function allocates a CameraConfiguration instance and returns it. The ownership of the instance is transferred to the caller. This is a perfect match for a std::unique_ptr<>, which the Camera::generateConfiguration() function already returns. Update PipelineHandler::generateConfiguration() to match it. This fixes a memory leak in one of the error return paths in the IPU3 pipeline handler. While at it, update the Camera::generateConfiguration() function documentation to drop the sentence that describes the ownership transfer, as that is implied by usage of std::unique_ptr<>. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src/apps/qcam/viewfinder_gl.h')
0 files changed, 0 insertions, 0 deletions