summaryrefslogtreecommitdiff
path: root/src/android/jpeg/encoder.h
diff options
context:
space:
mode:
authorPaul Elder <paul.elder@ideasonboard.com>2022-11-29 20:00:05 +0900
committerKieran Bingham <kieran.bingham@ideasonboard.com>2022-12-09 16:02:56 +0000
commit9a913eb9107483fcea01bd0e82c21e3733a5ddb2 (patch)
treeeaf88b1a31cbfdcaf5a17cb6246e65b9679b09a4 /src/android/jpeg/encoder.h
parenta6b1ff2e6caa632fe041e3eae569acb861e3353b (diff)
lc-compliance: simple_capture: Free Requests properly
In the simple capture tests, in the capture functions, the Requests were auto-deallocated by the function going out of scope after the test completed. However, before the end of the scope, the Framebuffers that the Requests referred to were manually freed. Thus when the Requests were deallocated, they tried to cancel their Framebuffers, which involve setting the status to cancelled, which obviously causes a segfault because the Framebuffers had already been freed. Fix this by moving the list of Requests to a member variable and deallocating them before deallocating the Framebuffers at stop() time. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Tested-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: NĂ­colas F. R. A. Prado <nfraprado@collabora.com> Tested-by: NĂ­colas F. R. A. Prado <nfraprado@collabora.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src/android/jpeg/encoder.h')
0 files changed, 0 insertions, 0 deletions