diff options
| author | Jacopo Mondi <jacopo@jmondi.org> | 2022-11-04 10:09:08 +0100 |
|---|---|---|
| committer | Jacopo Mondi <jacopo@jmondi.org> | 2022-11-23 18:44:36 +0100 |
| commit | 855228f7d5243278459f32fc372cbbecbde9cdfc (patch) | |
| tree | 5ad408fa4732656bd1268a8c5ca68f4c41b308d2 /include | |
| parent | 29d6d0e93b0193b70c6c0564eb424f2b6accf4a8 (diff) | |
ipa: rkisp1: Use IPAConfig in IPA::configure()
The RkISP1 implementation of IPA::configure() still uses the legacy
interface where sensor controls (and eventually lens controls) are
passed from the pipeline handler to the IPA in a map.
Since the introduction of mojom-based IPA interface definition, it is
possible to define custom data types and use them in the interface
definition between the pipeline handler and the IPA.
Align the RkISP1 IPA::configure() implementation with the one in the
IPU3 IPA module by using a custom data type instead of relying on a map
to pass controls to the IPA.
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/libcamera/ipa/rkisp1.mojom | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom index eaf3955e..36bf291e 100644 --- a/include/libcamera/ipa/rkisp1.mojom +++ b/include/libcamera/ipa/rkisp1.mojom @@ -8,6 +8,11 @@ module ipa.rkisp1; import "include/libcamera/ipa/core.mojom"; +struct IPAConfigInfo { + libcamera.IPACameraSensorInfo sensorInfo; + libcamera.ControlInfoMap sensorControls; +}; + interface IPARkISP1Interface { init(libcamera.IPASettings settings, uint32 hwRevision) @@ -15,9 +20,8 @@ interface IPARkISP1Interface { start() => (int32 ret); stop(); - configure(libcamera.IPACameraSensorInfo sensorInfo, - map<uint32, libcamera.IPAStream> streamConfig, - map<uint32, libcamera.ControlInfoMap> entityControls) + configure(IPAConfigInfo configInfo, + map<uint32, libcamera.IPAStream> streamConfig) => (int32 ret); mapBuffers(array<libcamera.IPABuffer> buffers); |