summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacopo Mondi <jacopo.mondi@ideasonboard.com>2023-12-21 11:34:15 +0100
committerJacopo Mondi <jacopo.mondi@ideasonboard.com>2023-12-29 11:33:30 +0100
commit8f9371c2807dd8acfb7b2c524b26ad4bb03f4028 (patch)
tree74a704ef0d3b814a5ccfe37168b5977d65256635
parenta4e6a5085b465216546b802e6bb9d55ecf278c63 (diff)
[DNI] apps: cam: Print require properties
Do not include, only to validate the implementation. When run on a VIMC camera: $ ./build/src/apps/cam/cam -c1 -p Using camera platform/vimc.0 Sensor B as cam0 Property: SystemDevices = [ 20740, 20741, 20742 ] Property: PixelArrayActiveAreas = [ (0, 0)/4096x2160 ] Property: PixelArraySize = 4096x2160 Property: Rotation = 0 [REQUIRED] Property: Model = Sensor B Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
-rw-r--r--src/apps/cam/camera_session.cpp3
-rw-r--r--src/libcamera/property_ids_core.yaml2
2 files changed, 4 insertions, 1 deletions
diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp
index 8447f932..d78ab2c1 100644
--- a/src/apps/cam/camera_session.cpp
+++ b/src/apps/cam/camera_session.cpp
@@ -165,7 +165,8 @@ void CameraSession::listProperties() const
const ControlId *id = properties::properties.at(key);
std::cout << "Property: " << id->name() << " = "
- << value.toString() << std::endl;
+ << value.toString()
+ << (id->required() ? " [REQUIRED]" : "") << std::endl;
}
}
diff --git a/src/libcamera/property_ids_core.yaml b/src/libcamera/property_ids_core.yaml
index 834454a4..f9e82c42 100644
--- a/src/libcamera/property_ids_core.yaml
+++ b/src/libcamera/property_ids_core.yaml
@@ -8,6 +8,7 @@ vendor: libcamera
controls:
- Location:
type: int32_t
+ required: true
description: |
Camera mounting location
enum:
@@ -29,6 +30,7 @@ controls:
- Rotation:
type: int32_t
+ required: true
description: |
The camera physical mounting rotation. It is expressed as the angular
difference in degrees between two reference systems, one relative to the