diff options
| author | Jacopo Mondi <jacopo@jmondi.org> | 2021-12-13 15:44:22 +0100 |
|---|---|---|
| committer | Jacopo Mondi <jacopo@jmondi.org> | 2021-12-13 19:31:02 +0100 |
| commit | a3122eeceafae4f37346ec40f24d20706473e962 (patch) | |
| tree | 99fd5156b73b707d0cd769a0653685b696b8b83a | |
| parent | 13fdf9d0dcd371e8b348e234847b133494be615d (diff) | |
test: fence: Check write return value
The ::write() function used to signal a framebuffer fence in the unit
test is marked with the 'warn_unused_result'.
When building in debugoptimized mode not checking for the return
value causes issues at build time:
/test/fence.cpp:254:2: error: ignoring return value of function declared with 'warn_unused_result' attribute
Fix that by checking the ::write() return value and emitting an
error message in case the write fails.
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reported-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
| -rw-r--r-- | test/fence.cpp | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/test/fence.cpp b/test/fence.cpp index d2dfc9b6..d2865398 100644 --- a/test/fence.cpp +++ b/test/fence.cpp @@ -251,7 +251,12 @@ void FenceTest::requestComplete(Request *request) void FenceTest::signalFence() { uint64_t value = 1; - write(efd2_, &value, sizeof(value)); + int ret; + + ret = write(efd2_, &value, sizeof(value)); + if (ret != sizeof(value)) + cerr << "Failed to signal fence" << endl; + dispatcher_->processEvents(); } |