diff options
| author | Mikhail Rudenko <mike.rudenko@gmail.com> | 2023-01-23 17:06:19 +0300 |
|---|---|---|
| committer | Jacopo Mondi <jacopo.mondi@ideasonboard.com> | 2023-01-25 18:43:44 +0100 |
| commit | 7986d3d3c17e1ca7c2aa488175a88a4743ed2203 (patch) | |
| tree | e68deede50b4ddb3448501b915b53046c79f7d53 | |
| parent | d500930e7dc20bf8c4ab5ec89d474a79c19a7e2c (diff) | |
ipa: rkisp1: Raise maximum analogue gain
Omnivision OV4689 sensor driver exposes maximum analogue gain of
16x. Raise kMaxAnalogueGain to 16.0, so that the full gain range can
be used.
Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
| -rw-r--r-- | src/ipa/rkisp1/algorithms/agc.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index e3470e25..22f70aba 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -36,9 +36,14 @@ namespace ipa::rkisp1::algorithms { LOG_DEFINE_CATEGORY(RkISP1Agc) -/* Limits for analogue gain values */ +/* + * Limits for analogue gain values + * + * \todo Remove the hard-coded limits and let the sensor helper specify + * the minimum and maximum allowed gain values. + */ static constexpr double kMinAnalogueGain = 1.0; -static constexpr double kMaxAnalogueGain = 8.0; +static constexpr double kMaxAnalogueGain = 16.0; /* \todo Honour the FrameDurationLimits control instead of hardcoding a limit */ static constexpr utils::Duration kMaxShutterSpeed = 60ms; |