summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2024-09-09 17:14:51 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2024-09-11 18:24:51 +0300
commit583901a714d50adf28f248ccdad5867050979058 (patch)
treecbe33bf564e06a6415ea36e765359143fe4a79d2
parent33a0b14e0ad70b30bf4c57ec085cb9921b2b97f5 (diff)
qcam: viewfinder_gl: Drop duplicate glClearColor()
There's no need to call glClearColor() twice before drawing any GL content. Drop the first call. This doesn't introduce any functional change. While at it, pass floats instead of doubles to glClearColor(), as required by the function. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Tested-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
-rw-r--r--src/apps/qcam/viewfinder_gl.cpp4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp
index 5be7bec5..b2096faf 100644
--- a/src/apps/qcam/viewfinder_gl.cpp
+++ b/src/apps/qcam/viewfinder_gl.cpp
@@ -533,8 +533,6 @@ void ViewFinderGL::initializeGL()
/* Create Vertex Shader */
if (!createVertexShader())
qWarning() << "[ViewFinderGL]: create vertex shader failed.";
-
- glClearColor(1.0f, 1.0f, 1.0f, 0.0f);
}
void ViewFinderGL::doRender()
@@ -821,7 +819,7 @@ void ViewFinderGL::paintGL()
}
if (image_) {
- glClearColor(0.0, 0.0, 0.0, 1.0);
+ glClearColor(0.0f, 0.0f, 0.0f, 1.0f);
glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
doRender();