summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacopo Mondi <jacopo@jmondi.org>2019-03-11 21:51:11 +0100
committerJacopo Mondi <jacopo@jmondi.org>2019-04-03 10:11:17 +0200
commitb95d12ac317f8f5a2a8e1441988b9e80ef798727 (patch)
tree53dc63515108a62302c479eeb6aa20bf07a7988a
parent9a1cdb7500f2cc4c01aa6f3e6ecf28bcbb5b448f (diff)
libcamera: ipu3: Limit resolution to 2560x1920
As the procedure to configure the intermediate sizes and the alignement requirements of the ImgU device have not been clarified yet, return as default configuration the (2560x1920) resolution that has been validated for both cameras. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
-rw-r--r--src/libcamera/pipeline/ipu3/ipu3.cpp13
1 files changed, 10 insertions, 3 deletions
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index 25434d52..a0040915 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -206,10 +206,17 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,
std::map<Stream *, StreamConfiguration> configs;
IPU3CameraData *data = cameraData(camera);
StreamConfiguration *config = &configs[&data->stream_];
- Size *maxSize = &data->.cio2_.maxSize_;
- config->width = maxSize->width;
- config->height = maxSize->height;
+ /*
+ * FIXME: Soraka: the maximum resolution reported by both sensors
+ * (2592x1944 for ov5670 and 4224x3136 for ov13858) are returned as
+ * default configurations but they're not correctly processed by the
+ * ImgU. Resolutions up tp 2560x1920 have been validated.
+ *
+ * \todo Clarify ImgU alignement requirements.
+ */
+ config->width = 2560;
+ config->height = 1920;
config->pixelFormat = V4L2_PIX_FMT_NV12;
config->bufferCount = IPU3_BUFFER_COUNT;