summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-08-23 21:50:04 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-09-21 13:50:30 +0300
commit2fa4ba01ffa2984e85ca77fce1430b6ae86ae84f (patch)
tree62523232e8db9307406cc6b2233873931c7ddce0
parent54557e25f2d478623839fe17f82700bb97fff0b2 (diff)
libcamera: Don't unnecessarily include event_notifier.h
The ipc_unixsocket.h and process.h internal headers don't need to include event_notifier.h, the former because a forward declaration suffices, and the latter because it doesn't use event notifiers. Remove the unnecessary include, and include signal.h instead which is required and was included indirectly through event_notifier.h. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
-rw-r--r--include/libcamera/internal/ipc_unixsocket.h4
-rw-r--r--include/libcamera/internal/process.h2
-rw-r--r--src/libcamera/ipc_unixsocket.cpp2
3 files changed, 6 insertions, 2 deletions
diff --git a/include/libcamera/internal/ipc_unixsocket.h b/include/libcamera/internal/ipc_unixsocket.h
index 9dcaaa26..e871b650 100644
--- a/include/libcamera/internal/ipc_unixsocket.h
+++ b/include/libcamera/internal/ipc_unixsocket.h
@@ -12,10 +12,12 @@
#include <sys/types.h>
#include <vector>
-#include <libcamera/event_notifier.h>
+#include <libcamera/signal.h>
namespace libcamera {
+class EventNotifier;
+
class IPCUnixSocket
{
public:
diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h
index 36595106..2688557c 100644
--- a/include/libcamera/internal/process.h
+++ b/include/libcamera/internal/process.h
@@ -10,7 +10,7 @@
#include <string>
#include <vector>
-#include <libcamera/event_notifier.h>
+#include <libcamera/signal.h>
namespace libcamera {
diff --git a/src/libcamera/ipc_unixsocket.cpp b/src/libcamera/ipc_unixsocket.cpp
index 701b2c51..5c8cce16 100644
--- a/src/libcamera/ipc_unixsocket.cpp
+++ b/src/libcamera/ipc_unixsocket.cpp
@@ -12,6 +12,8 @@
#include <sys/socket.h>
#include <unistd.h>
+#include <libcamera/event_notifier.h>
+
#include "libcamera/internal/log.h"
/**