diff options
| author | Kieran Bingham <kieran.bingham@ideasonboard.com> | 2019-03-19 11:32:09 +0000 |
|---|---|---|
| committer | Kieran Bingham <kieran.bingham@ideasonboard.com> | 2019-03-20 10:25:30 +0000 |
| commit | 18647a532483470d9f64bc6cb1bbeeda39c2670d (patch) | |
| tree | 8ab1218d75e20926af55490b5929df8105afb02a | |
| parent | af2144231eef8bc738b9de4acd2c41e296ae6ede (diff) | |
libcamera: media_device: Initialise local variable
The local variable ifaceId generates a compiler warning that it is used
without initialisation.
The loop, and check against the loop iterator, and the
topology.num_interfaces actually ensures that this isn't the case, and
that ifaceId can only be used when set to a valid ID.
The media_v2_interface.id field documents the ID as simply "Unique ID
for the interface" but does not specify if zero is a valid ID or not. As
such we don't further check the pre-initialised ID for validity and keep
the existing check on the iterator count to determine if the ID had been
discovered successfully.
Fixes: d4af90d72901 ("libcamera: media_device: Create entities with
major and minor numbers")
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
| -rw-r--r-- | src/libcamera/media_device.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp index ea460893..1e9024bf 100644 --- a/src/libcamera/media_device.cpp +++ b/src/libcamera/media_device.cpp @@ -516,7 +516,7 @@ struct media_v2_interface *MediaDevice::findInterface(const struct media_v2_topo { struct media_v2_link *links = reinterpret_cast<struct media_v2_link *> (topology.ptr_links); - unsigned int ifaceId; + unsigned int ifaceId = 0; unsigned int i; for (i = 0; i < topology.num_links; ++i) { |