diff options
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2021-02-22 12:21:26 +0200 |
|---|---|---|
| committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2021-02-22 13:17:22 +0200 |
| commit | 1612841ff156023ff23ae5c8f4d68eeb09840a2a (patch) | |
| tree | 27c6638f24be14f1e391842893f0fc4435c229e1 | |
| parent | 13a7ed7b1f1fbeac2252fae9fd9b949b6ad048f2 (diff) | |
libcamera: raspberrypi: Drop std::move() where misleading
Usage of std::move() on a const lvalue will produce a const rvalue,
which the compiler will bind to the const lvalue reference of the
constructor or assignement operator. This results in the object being
copied, not moved. Drop std::move() in that case as it's misleading.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
| -rw-r--r-- | src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 5bab313b..46b7c6db 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1289,7 +1289,7 @@ void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList & /* Fill the Request metadata buffer with what the IPA has provided */ Request *request = requestQueue_.front(); - request->metadata() = std::move(controls); + request->metadata() = controls; /* * Also update the ScalerCrop in the metadata with what we actually @@ -1338,7 +1338,7 @@ void RPiCameraData::embeddedComplete(uint32_t bufferId) void RPiCameraData::setIspControls(const ControlList &controls) { - ControlList ctrls = std::move(controls); + ControlList ctrls = controls; if (ctrls.contains(V4L2_CID_USER_BCM2835_ISP_LENS_SHADING)) { ControlValue &value = |