summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKieran Bingham <kieran.bingham@ideasonboard.com>2021-03-11 12:51:45 +0000
committerKieran Bingham <kieran.bingham@ideasonboard.com>2021-03-29 12:48:14 +0100
commit6084217cd3b52ba5677e3ca2de0e21008fdaa735 (patch)
tree95ad909cdbb01a99a529498ee96701c9f14cc9fc
parentaa7d4ebf96d1b339ad1e1221d1154db6b845a1e2 (diff)
libcamera: pipeline: ipu3: frames: Use the request sequence
For all frame indexes, use the same sequence number as generated by the Request object. This allows clear matching of what operations occurred to which request. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
-rw-r--r--src/libcamera/pipeline/ipu3/frames.cpp4
-rw-r--r--src/libcamera/pipeline/ipu3/frames.h1
2 files changed, 1 insertions, 4 deletions
diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp
index e8eb1c51..03e8131c 100644
--- a/src/libcamera/pipeline/ipu3/frames.cpp
+++ b/src/libcamera/pipeline/ipu3/frames.cpp
@@ -18,7 +18,6 @@ namespace libcamera {
LOG_DECLARE_CATEGORY(IPU3)
IPU3Frames::IPU3Frames()
- : nextId_(0)
{
}
@@ -31,7 +30,6 @@ void IPU3Frames::init(const std::vector<std::unique_ptr<FrameBuffer>> &paramBuff
for (const std::unique_ptr<FrameBuffer> &buffer : statBuffers)
availableStatBuffers_.push(buffer.get());
- nextId_ = 0;
frameInfo_.clear();
}
@@ -43,7 +41,7 @@ void IPU3Frames::clear()
IPU3Frames::Info *IPU3Frames::create(Request *request)
{
- unsigned int id = nextId_++;
+ unsigned int id = request->sequence();
if (availableParamBuffers_.empty()) {
LOG(IPU3, Error) << "Parameters buffer underrun";
diff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h
index 106e5c15..4acdf48e 100644
--- a/src/libcamera/pipeline/ipu3/frames.h
+++ b/src/libcamera/pipeline/ipu3/frames.h
@@ -53,7 +53,6 @@ private:
std::queue<FrameBuffer *> availableParamBuffers_;
std::queue<FrameBuffer *> availableStatBuffers_;
- unsigned int nextId_;
std::map<unsigned int, std::unique_ptr<Info>> frameInfo_;
};